test: remove $request->uri and fix incorrect assertions#6682
Merged
kenjis merged 2 commits intocodeigniter4:developfrom Oct 15, 2022
Merged
test: remove $request->uri and fix incorrect assertions#6682kenjis merged 2 commits intocodeigniter4:developfrom
kenjis merged 2 commits intocodeigniter4:developfrom
Conversation
The test is when BaseURL does not have `index.php`, so $config->indexPage should be empty string.
MGatner
reviewed
Oct 14, 2022
MGatner
approved these changes
Oct 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #5344
IncomingRequest::$uriwill be protected.$request->getUri()->getPath()does not start with/.IncomingRequest::$uriis a bit different from a normal URI object.CodeIgniter4/system/HTTP/IncomingRequest.php
Lines 60 to 71 in a3eedf4
Checklist: