Skip to content

chore: add extensions in suggest in composer.json#6731

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:add-composer-suggest
Oct 21, 2022
Merged

chore: add extensions in suggest in composer.json#6731
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:add-composer-suggest

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Oct 21, 2022

Description

  • add extensions in suggest

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

MGatner
MGatner approved these changes Oct 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I having déjà vu? I thought we did this already?

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Oct 21, 2022

You saw https://github.com/codeigniter4/CodeIgniter4/pull/6677/files
This is a new PR!

@kenjis kenjis merged commit 09eca38 into codeigniter4:develop Oct 21, 2022
@kenjis kenjis deleted the add-composer-suggest branch October 21, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @MGatner