Skip to content

docs: improve database#6732

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-docs-database
Oct 21, 2022
Merged

docs: improve database#6732
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-docs-database

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Oct 21, 2022

Description
Fixes #6727

  • add note of dots in database/table/column names
  • fix RST format

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Oct 21, 2022
Copy link
Copy Markdown
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the purpose of the report was to cover this feature.
Thanks anyway.

@kenjis kenjis merged commit fd911fe into codeigniter4:develop Oct 21, 2022
@kenjis kenjis deleted the fix-docs-database branch October 21, 2022 11:42
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Oct 21, 2022

Probably supporting dots is impossible with the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Migration failing when the mysql database contians dots

3 participants