Skip to content

Remove unneeded implements#6748

Merged
samsonasik merged 1 commit intocodeigniter4:developfrom
paulbalandan:unneeded-implements
Oct 24, 2022
Merged

Remove unneeded implements#6748
samsonasik merged 1 commit intocodeigniter4:developfrom
paulbalandan:unneeded-implements

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan commented Oct 24, 2022

Description
The abstract class already implements the interface.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Oct 24, 2022
@samsonasik samsonasik merged commit 7c471f1 into codeigniter4:develop Oct 24, 2022
@samsonasik
Copy link
Copy Markdown
Member

samsonasik commented Oct 24, 2022

Thank you @paulbalandan

@paulbalandan paulbalandan deleted the unneeded-implements branch October 24, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan @samsonasik