Fix CreateDatabase leaving altered database config in connection#6856
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Nov 14, 2022
Merged
Conversation
kenjis
approved these changes
Nov 14, 2022
MGatner
approved these changes
Nov 14, 2022
Member
MGatner
left a comment
There was a problem hiding this comment.
Thanks for the investigation and thorough explanation! Glad to see one more of these local-versus-pipeline mysteries cleared up.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
vendor/bin/phpunit --group DatabaseLiveeither on GA or local, MigrationRunnerTest fails:On GA:
On local: (forgive the irrelevant failures)
After this PR:
In local:
The reason for this is that all database live tests uses the shared DB connection (from
Database::connect()). WhenCreateDatabaseTestruns for SQLite3, the tests alter the database to usefoobar.dbin theConfig\Databaseinstance. On cleanup, the altered config is reset. However, the protectedDatabase::$instancesarray contains the shared DB connection which still uses the altered config. RunningDatabase::connect(null, false)will effectively flush the old shared connection and create a new one using the fresh config.Checklist: