Skip to content

Refactor AlterTableTest#6858

Merged
kenjis merged 3 commits intocodeigniter4:developfrom
paulbalandan:refactor-alter-table-test
Nov 15, 2022
Merged

Refactor AlterTableTest#6858
kenjis merged 3 commits intocodeigniter4:developfrom
paulbalandan:refactor-alter-table-test

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan commented Nov 14, 2022

Description

  • Run tests only in SQLite3
  • Use in-memory database so that stray database file is not left

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Nov 14, 2022
@kenjis kenjis merged commit 5de3a98 into codeigniter4:develop Nov 15, 2022
@paulbalandan paulbalandan deleted the refactor-alter-table-test branch November 15, 2022 01:36
@paulbalandan paulbalandan mentioned this pull request Nov 15, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulbalandan @kenjis @michalsn @MGatner