Skip to content

refactor: replace time() with Time into Debug and Cookie class.#6860

Merged
kenjis merged 4 commits intocodeigniter4:developfrom
ping-yee:refactor-replace-time
Nov 15, 2022
Merged

refactor: replace time() with Time into Debug and Cookie class.#6860
kenjis merged 4 commits intocodeigniter4:developfrom
ping-yee:refactor-replace-time

Conversation

@ping-yee
Copy link
Copy Markdown
Contributor

Description
See #6815

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 14, 2022
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice micro-timing 🤗

Comment thread system/Debug/Toolbar.php Outdated
Comment thread system/Debug/Toolbar/Collectors/Database.php Outdated
Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kenjis kenjis merged commit 9e09063 into codeigniter4:develop Nov 15, 2022
@ping-yee ping-yee deleted the refactor-replace-time branch April 25, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants