Skip to content

test: add @var in ExampleDatabaseTest#6873

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:fix-ExampleDatabaseTest
Nov 16, 2022
Merged

test: add @var in ExampleDatabaseTest#6873
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:fix-ExampleDatabaseTest

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Nov 16, 2022

Description
To prevent PHPStan from reporting errors.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

$this->setPrivateProperty($model, 'useSoftDeletes', true);
$this->setPrivateProperty($model, 'tempUseSoftDeletes', true);

/** @var stdClass $object */
Copy link
Copy Markdown
Member

@samsonasik samsonasik Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdClass should be imported or use \stdClass instead.

Suggested change
/** @var stdClass $object */
/** @var \stdClass $object */

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current sample test files has no namespace.

It seems better to have a namespace and can be autoloaded.

@kenjis kenjis merged commit cef02c8 into codeigniter4:develop Nov 16, 2022
@kenjis kenjis deleted the fix-ExampleDatabaseTest branch November 16, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants