docs: improve Tutorial v4.3#6900
Merged
kenjis merged 18 commits intocodeigniter4:4.3from Dec 3, 2022
Merged
Conversation
Remove the word `here`. Make the path relative.
The slug should be unique.
Use validateData() instead of validate() because it is more secure. If we use validate(), we cannot know which data is validated. Use new validation_list_errors(). Use set_value() to show old input data. Update description for v4.3.
MGatner
reviewed
Nov 24, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
You used php:func: for a number of internal functions. I thought that would create a link out to the PHP docs? Or am I thinking of another syntax?
Member
Author
No. It creates a link to the |
kenjis
force-pushed
the
fix-docs-tutorial-4.3
branch
from
9feb670 to
94f6d84
Compare
kenjis
force-pushed
the
fix-docs-tutorial-4.3
branch
from
94f6d84 to
510441f
Compare
MGatner
approved these changes
Nov 25, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Looks good! I haven't walked through the tutorial, might be good to do before 4.3 goes live at some point.
Member
Author
|
I pushed my working repository: |
paulbalandan
approved these changes
Dec 2, 2022
Member
|
@kenjis Please proceed; I won't get to walk through this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validateData()instead ofvalidate()because it is more secure.validate(), we cannot know which data is validated.validation_list_errors().set_value()to show old input data.Checklist: