Skip to content

docs: improve model.rst#6962

Merged
kenjis merged 17 commits intocodeigniter4:developfrom
kenjis:fix-docs-model.rst
Dec 9, 2022
Merged

docs: improve model.rst#6962
kenjis merged 17 commits intocodeigniter4:developfrom
kenjis:fix-docs-model.rst

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Dec 9, 2022

Description

  • add missing things
  • add explanation for "Working with Query Builder"

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Dec 9, 2022
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very nice improvement. Some suggestions inline.

Comment thread user_guide_src/source/models/model.rst Outdated
Comment thread user_guide_src/source/models/model.rst Outdated
Comment thread user_guide_src/source/models/model.rst Outdated
Co-authored-by: MGatner <mgatner@icloud.com>
@kenjis kenjis requested a review from MGatner December 9, 2022 12:11
@kenjis kenjis merged commit 6b06020 into codeigniter4:develop Dec 9, 2022
@kenjis kenjis deleted the fix-docs-model.rst branch December 9, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants