Skip to content

[PHPStan] Fix PHPStan notice on PHPStan 1.9.3#6975

Merged
samsonasik merged 1 commit intocodeigniter4:developfrom
samsonasik:fix-phpstan-193
Dec 13, 2022
Merged

[PHPStan] Fix PHPStan notice on PHPStan 1.9.3#6975
samsonasik merged 1 commit intocodeigniter4:developfrom
samsonasik:fix-phpstan-193

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Description

Fix PHPStan notice on PHPStan 1.9.3:

Run vendor/bin/phpstan analyse
Note: Using configuration file /home/runner/work/CodeIgniter4/CodeIgniter4/phpstan.neon.dist.
   0/434 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
 360/434 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░]  82%
 434/434 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Error: Variable $cols in isset() always exists and is not nullable.
 ------ -------------------------------------------------------------- 
  Line   system/CLI/CLI.php                                            
 ------ -------------------------------------------------------------- 
  985    Variable $cols in isset() always exists and is not nullable.  

Ref https://github.com/codeigniter4/CodeIgniter4/actions/runs/3686745072/jobs/6239400007#step:11:15

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Copy Markdown
Member Author

All green 🎉 , let's merge

@samsonasik samsonasik merged commit 821abab into codeigniter4:develop Dec 13, 2022
@samsonasik samsonasik deleted the fix-phpstan-193 branch December 13, 2022 16:06
@datamweb datamweb mentioned this pull request Dec 20, 2022
5 tasks
@kenjis kenjis added the refactor Pull requests that refactor code label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants