Skip to content

docs: add background color for versionadded and deprecated#7018

Merged
kenjis merged 2 commits intocodeigniter4:4.3from
kenjis:docs-update-css
Dec 27, 2022
Merged

docs: add background color for versionadded and deprecated#7018
kenjis merged 2 commits intocodeigniter4:4.3from
kenjis:docs-update-css

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Dec 25, 2022

Description

  • add background color for versionadded and deprecated

Screenshot 2022-12-25 9 18 22

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added documentation Pull requests for documentation only 4.3 labels Dec 25, 2022
Copy link
Copy Markdown
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.
Test break.

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Dec 25, 2022

The check failure is not related to this PR.
Perhaps the SCSS output has been changed at some time.

Run if [[ -n "$(git status --porcelain 2>/dev/null)" ]]; then
Your changes to the SCSS files did not match the expected CSS output.
diff --git a/system/Debug/Toolbar/Views/toolbar.css b/system/Debug/Toolbar/Views/toolbar.css
index 4cb379c..744d939 100644
--- a/system/Debug/Toolbar/Views/toolbar.css
+++ b/system/Debug/Toolbar/Views/toolbar.css
@@ -427,8 +427,8 @@
     -webkit-box-shadow: 0 0 4px #DFDFDF;
   }
   #debug-icon a:active,
-#debug-icon a:link,
-#debug-icon a:visited {
+  #debug-icon a:link,
+  #debug-icon a:visited {
     color: #DD8615;
   }
   #debug-bar {
@@ -436,17 +436,17 @@
     color: #DFDFDF;
   }
   #debug-bar h1,
-#debug-bar h2,
-#debug-bar h3,
-#debug-bar p,
-#debug-bar a,
-#debug-bar button,
-#debug-bar table,
-#debug-bar thead,
-#debug-bar tr,
-#debug-bar td,
-#debug-bar button,
-#debug-bar .toolbar {
+  #debug-bar h2,
+  #debug-bar h3,
+  #debug-bar p,
+  #debug-bar a,
+  #debug-bar button,
+  #debug-bar table,
+  #debug-bar thead,
+  #debug-bar tr,
+  #debug-bar td,
+  #debug-bar button,
+  #debug-bar .toolbar {
     background-color: transparent;
     color: #DFDFDF;
   }
@@ -498,7 +498,7 @@
     color: #DFDFDF;
   }
   #debug-bar #toolbar-position,
-#debug-bar #toolbar-theme {
+  #debug-bar #toolbar-theme {
     filter: brightness(0) invert(0.6);
   }
   #debug-bar .ci-label.active {
@@ -518,7 +518,7 @@
     -webkit-box-shadow: 0 -1px 4px #434343;
   }
   #debug-bar .timeline th,
-#debug-bar .timeline td {
+  #debug-bar .timeline td {
     border-color: #434343;
   }
   #debug-bar .timeline .timer {
Error: Process completed with exit code 1.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3773523222/jobs/6415034257

Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding small padding would be good.

Comment thread user_guide_src/source/_static/css/citheme.css
Comment thread user_guide_src/source/_static/css/citheme.css Outdated
@kenjis kenjis mentioned this pull request Dec 26, 2022
1 task
kenjis and others added 2 commits December 27, 2022 11:04
@kenjis kenjis merged commit ead1b13 into codeigniter4:4.3 Dec 27, 2022
@kenjis kenjis deleted the docs-update-css branch December 27, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants