Skip to content

docs: replace types mixed in CacheInterface and BaseHandler file.#7023

Merged
kenjis merged 3 commits intocodeigniter4:developfrom
ping-yee:docs-replace-mixed-cache-interface
Dec 26, 2022
Merged

docs: replace types mixed in CacheInterface and BaseHandler file.#7023
kenjis merged 3 commits intocodeigniter4:developfrom
ping-yee:docs-replace-mixed-cache-interface

Conversation

@ping-yee
Copy link
Copy Markdown
Contributor

@ping-yee ping-yee commented Dec 25, 2022

Description
See #6310
It seems the return types of increment and decrement functions is int or bool, so I only leave the bool|int at that two functions.
And wish you all a merry Christmas!

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Comment thread system/Cache/CacheInterface.php Outdated
Comment thread system/Cache/CacheInterface.php Outdated
Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 958f301 into codeigniter4:develop Dec 26, 2022
@ddevsr ddevsr added the documentation Pull requests for documentation only label Jan 1, 2023
@ping-yee ping-yee deleted the docs-replace-mixed-cache-interface branch January 22, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants