Skip to content

chore: Update admin/userguide #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2023
Merged

chore: Update admin/userguide #7059

merged 4 commits into from
Jan 8, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jan 7, 2023

Description
See codeigniter4/userguide#37 (comment)

  • copy the latest repo-specific files from codeigniter4/userguide
  • update deploy script

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Jan 7, 2023
Closed
@kenjis kenjis changed the title chore: Update admin userguide chore: Update admin/userguide Jan 7, 2023
paulbalandan
paulbalandan reviewed Jan 7, 2023
View reviewed changes
@kenjis
Copy link
Member Author

kenjis commented Jan 7, 2023

The source for GitHub Pages is master /docs:
Screenshot 2023-01-07 10 15 25

So I think the file https://github.com/codeigniter4/userguide/blob/master/.nojekyll is not necessary.
I did not copy it to admin/userguide.

MGatner
MGatner approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenjis kenjis merged commit 3459fed into codeigniter4:develop Jan 8, 2023
@kenjis kenjis deleted the update-admin-userguide branch January 8, 2023 23:58
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @MGatner @paulbalandan