Skip to content

fix close-pull-request.yml failed#7146

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
totoprayogo1916:close-pr-appstarter
Jan 18, 2023
Merged

fix close-pull-request.yml failed#7146
paulbalandan merged 1 commit intocodeigniter4:developfrom
totoprayogo1916:close-pr-appstarter

Conversation

@totoprayogo1916
Copy link
Copy Markdown
Contributor

@totoprayogo1916 totoprayogo1916 commented Jan 17, 2023

Description
fix #7141

  • Add permission
  • use GitHub CLI

Tested: https://github.com/totoprayogo1916/github-playground/pull/3

Checklist:

  • Securely signed commits

Comment thread admin/starter/.github/workflows/close-pull-request.yml Outdated
Comment thread admin/starter/.github/workflows/close-pull-request.yml Outdated
Comment thread admin/starter/.github/workflows/close-pull-request.yml Outdated
Comment thread admin/starter/.github/workflows/close-pull-request.yml
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Jan 17, 2023
- add types for pull_request_target
- add permission
- use GitHub CLI
@totoprayogo1916
Copy link
Copy Markdown
Contributor Author

Can you also update the following?

* https://github.com/codeigniter4/CodeIgniter4/blob/develop/admin/framework/.github/workflows/close-pull-request.yml
* https://github.com/codeigniter4/CodeIgniter4/blob/develop/admin/userguide/.github/workflows/close-pull-request.yml

updated @kenjis

Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paulbalandan paulbalandan merged commit ccef2ac into codeigniter4:develop Jan 18, 2023
@paulbalandan
Copy link
Copy Markdown
Member

Thank you, @totoprayogo1916

@totoprayogo1916 totoprayogo1916 deleted the close-pr-appstarter branch January 18, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

close-pull-request.yml failed

3 participants