Skip to content

docs: improve installation#7167

Merged
kenjis merged 5 commits intocodeigniter4:developfrom
kenjis:fix-docs-installing
Jan 30, 2023
Merged

docs: improve installation#7167
kenjis merged 5 commits intocodeigniter4:developfrom
kenjis:fix-docs-installing

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Jan 23, 2023 •
edited
Loading

Description

  • improvements
  • fix typos

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jan 23, 2023
MGatner
MGatner approved these changes Jan 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to move away from tests/ eventually but these additions are good for now.

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Jan 27, 2023

Oh, all the files in tests/ are kind of samples, so we don't need to check them?

@kenjis kenjis force-pushed the fix-docs-installing branch from 4a07dfa to 59261c3 Compare January 30, 2023 02:21
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Jan 30, 2023

All files in tests/ are sample files and upgrade users do not need to check them.
Therefore, I deleted the added tests/ folder.

@kenjis kenjis merged commit 46a5d1e into codeigniter4:develop Jan 30, 2023
@kenjis kenjis deleted the fix-docs-installing branch January 30, 2023 02:25
@MGatner
Copy link
Copy Markdown
Member

MGatner commented Jan 30, 2023

Thanks! I think that's best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @MGatner