Skip to content

docs: replace type mixed in Cookie class.#7352

Merged
kenjis merged 8 commits intocodeigniter4:developfrom
ping-yee:replace-mixed-cookie
Apr 9, 2023
Merged

docs: replace type mixed in Cookie class.#7352
kenjis merged 8 commits intocodeigniter4:developfrom
ping-yee:replace-mixed-cookie

Conversation

@ping-yee
Copy link
Copy Markdown
Contributor

Description
See #6310

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Comment thread system/Cookie/Cookie.php Outdated
Comment thread system/Cookie/Cookie.php Outdated
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Mar 14, 2023

Error: Parameter #2 $array of function implode expects array<string>, array<int, bool|int|object|string> given.
 ------ ---------------------------------------------------------------- 
  Line   system/Cookie/CookieStore.php                                   
 ------ ---------------------------------------------------------------- 
  146    Parameter #2 $array of function implode expects array<string>,  
         array<int, bool|int|object|string> given.                       
 ------ ---------------------------------------------------------------- 

https://github.com/codeigniter4/CodeIgniter4/actions/runs/4407171630/jobs/7720467402

@ping-yee
Copy link
Copy Markdown
Contributor Author

@kenjis I have been fixed this problem of phpstan.

Comment thread system/Cookie/Cookie.php Outdated
Comment thread system/Cookie/CookieInterface.php Outdated
Comment thread tests/system/Cookie/CookieTest.php Outdated
Comment thread tests/system/Cookie/CookieTest.php Outdated
Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kenjis kenjis merged commit 5b3ea6c into codeigniter4:develop Apr 9, 2023
@ping-yee ping-yee deleted the replace-mixed-cookie branch April 13, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants