Skip to content

docs: improve auto routing#7414

Merged
kenjis merged 7 commits intocodeigniter4:developfrom
kenjis:docs-auto-routing
Apr 12, 2023
Merged

docs: improve auto routing#7414
kenjis merged 7 commits intocodeigniter4:developfrom
kenjis:docs-auto-routing

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Apr 7, 2023

Description

  • improve description for Default Controller in Auto-Routing
  • update for consistency

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Apr 7, 2023
Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question is not very important, but why are we changing folder to directory everywhere? Do we stick to this convention on other pages? I have nothing against it, though.

Comment thread user_guide_src/source/incoming/controllers.rst Outdated
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Apr 10, 2023

This is an explanation of subdirectories in Controllers, and there is no need to use the two terms folder and directory. Suddenly changing what we call a directory to a folder may confuse beginners.

I do not intend to change all folders in the user guide to directories.

@kenjis kenjis requested a review from michalsn April 11, 2023 10:18
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Apr 12, 2023

Can someone review?

@kenjis kenjis merged commit 987f3da into codeigniter4:develop Apr 12, 2023
@kenjis kenjis deleted the docs-auto-routing branch April 12, 2023 07:10
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Apr 12, 2023

Thank you! @michalsn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants