docs: fix PHPDoc types in Route class.#7442
Merged
MGatner merged 2 commits intocodeigniter4:developfrom Apr 23, 2023
Merged
Conversation
kenjis
reviewed
Apr 20, 2023
| * @return mixed | ||
| */ | ||
| public function add(string $from, $to, ?array $options = null); | ||
| public function add(string $from, $to, ?array $options = null): self; |
Contributor
Author
There was a problem hiding this comment.
I have been removed.
MGatner
requested changes
Apr 21, 2023
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Please adjust this to docblock changes only
Contributor
Author
|
OK, I'll change it later. |
Contributor
Author
|
I have been fixed and review please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #6310
Checklist: