Skip to content

test: fix TestResponseTest#7599

Merged
kenjis merged 5 commits intocodeigniter4:developfrom
kenjis:fix-TestResponseTest
Jul 3, 2023
Merged

test: fix TestResponseTest#7599
kenjis merged 5 commits intocodeigniter4:developfrom
kenjis:fix-TestResponseTest

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Jun 19, 2023

Description

  • fix test code
  • rename test methods
  • fix @param types
  • delete FeatureTestTraitTest::testCallWithJsonRequestObject() and add testAssertJsonExactObject()

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

kenjis added 5 commits June 19, 2023 18:26
@kenjis
test: change test method names
dbfd8ff 
Add the method name to test.
@kenjis
test: add param type for Response body
e534332
@kenjis
fix: incorrect tests
66526a8 
Cannot set non-string to Response body.
@kenjis
test: remove testCallWithJsonRequestObject() and add testAssertJsonEx…
2bcebad 
…actObject()

testCallWithJsonRequestObject() is not a test for FeatureTestTrait.
@kenjis
docs: fix @param types
202b467
@kenjis kenjis added the testing Pull requests that changes tests only label Jun 19, 2023
@kenjis kenjis mentioned this pull request Jun 19, 2023
Closed
MGatner
MGatner approved these changes Jul 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenjis kenjis merged commit da41b55 into codeigniter4:develop Jul 3, 2023
@kenjis kenjis deleted the fix-TestResponseTest branch July 3, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @MGatner