Skip to content

Remove parallel.processTimeout#7666

Merged
kenjis merged 1 commit intodevelopfrom
remove-process-timeout
Jul 6, 2023
Merged

Remove parallel.processTimeout#7666
kenjis merged 1 commit intodevelopfrom
remove-process-timeout

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
Default PHPStan parallel process timeout is 600.0 seconds so we should take advantage of the longer time.
https://github.com/phpstan/phpstan-src/blob/2861699cdd2d522ae3062559db6f11335844e3fe/conf/config.neon#L116-L121

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update the template at DevKit as well.

@paulbalandan
Copy link
Copy Markdown
Member Author

devkit seems to not use the parallel.processTimeout setting

@kenjis kenjis merged commit 9977c31 into develop Jul 6, 2023
@kenjis kenjis deleted the remove-process-timeout branch July 6, 2023 20:42
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Jul 6, 2023

@paulbalandan Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants