Adjust registering of custom fixers for PHP 8.0+ only#7712
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Jul 18, 2023
Merged
Adjust registering of custom fixers for PHP 8.0+ only#7712paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan merged 1 commit intocodeigniter4:developfrom
Conversation
samsonasik
approved these changes
Jul 17, 2023
Member
|
What happened when we (or contributors) use PHP 7.4? |
Member
Author
|
If you are using |
Member
|
Until we stop supporting PHP 7.4, I guess the only way is to fix the version of php-cs-fixer so that PHP 7.4 does not cause the error? |
a6123d6 to
00c7086
Compare
Member
Author
|
I pushed a different approach. I disabled registering custom fixers for PHP 7.4. Only for PHP 8.0 and above |
1 task
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
php-cs-fixerrecently adjusted the return types of itsPregmethods. Yes, that class is internal butcs-configdepended on that. With the return type change, it used the nativepreg_*functions instead. Sincecs-configneeds^8.0.1the fix won't work with 7.4.Checklist: