Skip to content

[Rector] Enable skipped GetMockBuilderGetMockToCreateMockRector on EmailTest.php#7714

Merged
samsonasik merged 1 commit intocodeigniter4:developfrom
samsonasik:enable-skip-get-mock
Jul 18, 2023
Merged

[Rector] Enable skipped GetMockBuilderGetMockToCreateMockRector on EmailTest.php#7714
samsonasik merged 1 commit intocodeigniter4:developfrom
samsonasik:enable-skip-get-mock

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jul 17, 2023

Description

The GetMockBuilderGetMockToCreateMockRector bug was fixed at PR:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jul 17, 2023

@paulbalandan cs error seems unrelated https://github.com/codeigniter4/CodeIgniter4/actions/runs/5581047391/jobs/10198766759?pr=7714#step:7:14

@samsonasik samsonasik merged commit cc61150 into codeigniter4:develop Jul 18, 2023
@samsonasik samsonasik deleted the enable-skip-get-mock branch July 18, 2023 08:38
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jul 18, 2023

Thank you @kenjis for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner Awaiting requested review from MGatner

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @kenjis