Skip to content

Dev: Remove the Honeypot and I18n ignore errors in phpstan-baseline.php#7770

Merged
kenjis merged 7 commits intocodeigniter4:developfrom
ping-yee:230804-phpstan-honeypot-i18n
Aug 8, 2023
Merged

Dev: Remove the Honeypot and I18n ignore errors in phpstan-baseline.php#7770
kenjis merged 7 commits intocodeigniter4:developfrom
ping-yee:230804-phpstan-honeypot-i18n

Conversation

@ping-yee
Copy link
Copy Markdown
Contributor

@ping-yee ping-yee commented Aug 3, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Comment thread system/Honeypot/Exceptions/HoneypotException.php Outdated
Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis added the stale Pull requests with conflicts label Aug 6, 2023
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 6, 2023

Please rebase to resolve conflict.

@ping-yee ping-yee force-pushed the 230804-phpstan-honeypot-i18n branch from 0436792 to 25248a5 Compare August 7, 2023 10:28
@ddevsr ddevsr removed the stale Pull requests with conflicts label Aug 8, 2023
@kenjis kenjis merged commit e0a1094 into codeigniter4:develop Aug 8, 2023
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Aug 8, 2023

@ping-yee Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants