docs: improve cookies#7778
Merged
kenjis merged 16 commits intocodeigniter4:developfrom Aug 9, 2023
Merged
Conversation
Now the Cookie class has nothing to do with getting incomming cookies.
kenjis
force-pushed
the
fix-docs-cookies
branch
from
0c548d1 to
72e7d1c
Compare
datamweb
reviewed
Aug 4, 2023
|
|
||
| use CodeIgniter\Cookie\Cookie; | ||
| use Config\Services; | ||
| use DateTime; |
Contributor
There was a problem hiding this comment.
CI4 has a class use CodeIgniter\I18n\Time;. These documents are codeigniter, I think it is better to use the internal library.
Just a personal preference.
Member
Author
There was a problem hiding this comment.
Changed to use undocumented max-age.
datamweb
approved these changes
Aug 4, 2023
MGatner
approved these changes
Aug 8, 2023
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Maybe all our config classes should include "Config" in the name? 🤔
Member
Author
It may be better. |
Member
|
Something to consider for v5. I frequently have to alias my imports so I can use both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See https://forum.codeigniter.com/showthread.php?tid=88176
Checklist: