Fix: Repair conflicts and emove the Debug ignore errors.#7801
Merged
kenjis merged 4 commits intocodeigniter4:developfrom Aug 11, 2023
Merged
Fix: Repair conflicts and emove the Debug ignore errors.#7801kenjis merged 4 commits intocodeigniter4:developfrom
Debug ignore errors.#7801kenjis merged 4 commits intocodeigniter4:developfrom
Conversation
kai890707
changed the title
Debug ignore errors.
kenjis
reviewed
Aug 10, 2023
| * @codeCoverageIgnore | ||
| * | ||
| * @return void | ||
| * @phpstan-return never|void |
Member
There was a problem hiding this comment.
It seems never is not returned. See https://phpstan.org/writing-php-code/phpdoc-types#bottom-type
Suggested change
| * @phpstan-return never|void |
Contributor
Author
There was a problem hiding this comment.
I changed there to @phpstan-return void .
Member
There was a problem hiding this comment.
If @return and @phpstan-return are the same, @phpstan-return is not needed.
Remove it.
kenjis
reviewed
Aug 10, 2023
| * @param ResponseInterface $response | ||
| * | ||
| * @return void | ||
| * @phpstan-return never|void |
Member
There was a problem hiding this comment.
Is there any exit() or die() in this method?
Contributor
Author
There was a problem hiding this comment.
There does not include exit() or die().
So, I changed there to @phpstan-return void.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #7731
Sorry, There was a conflict with a previous modification (#7796) and due to my operational issues I have reorganized the complete modification into a new PR.
Checklist: