Skip to content

[PHPStan] Add @var string[] on array of string, detected by enable StringifyStrNeedlesRector#7940

Merged
samsonasik merged 8 commits intocodeigniter4:developfrom
samsonasik:str-vars
Sep 14, 2023
Merged

[PHPStan] Add @var string[] on array of string, detected by enable StringifyStrNeedlesRector#7940
samsonasik merged 8 commits intocodeigniter4:developfrom
samsonasik:str-vars

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Sep 13, 2023 •
edited by kenjis
Loading

Description

with enable StringifyStrNeedlesRector, the cast (string) is applied to array data with mixed type.

This PR apply @var string[] so it skipped by StringifyStrNeedlesRector correctly.

https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#stringifystrneedlesrector

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis reviewed Sep 14, 2023
View reviewed changes
Comment thread system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php Outdated
kenjis
kenjis reviewed Sep 14, 2023
View reviewed changes
Comment thread system/Email/Email.php Outdated
kenjis
kenjis reviewed Sep 14, 2023
View reviewed changes
Comment thread system/Router/RouteCollection.php Outdated
kenjis
kenjis reviewed Sep 14, 2023
View reviewed changes
Comment thread system/Router/RouteCollection.php Outdated
samsonasik and others added 4 commits September 14, 2023 12:30
@samsonasik @kenjis
Update system/Commands/Utilities/Routes/AutoRouterImproved/Controller…
4549a7c 
…MethodReader.php

Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik @kenjis
Update system/Email/Email.php
02bcc04 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik @kenjis
Update system/Router/RouteCollection.php
aa5dd51 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik @kenjis
Update system/Router/RouteCollection.php
8d9afe0 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Sep 14, 2023

@kenjis updated 👍

datamweb
datamweb reviewed Sep 14, 2023
View reviewed changes
Comment thread system/Router/RouteCollection.php Outdated
@samsonasik @datamweb
Update system/Router/RouteCollection.php
2ba4576 
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
samsonasik
samsonasik commented Sep 14, 2023
View reviewed changes
Comment thread system/Commands/Utilities/Routes/AutoRouterImproved/ControllerMethodReader.php Outdated
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Sep 14, 2023

@datamweb updated 👍

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Sep 14, 2023

Thank you @kenjis @datamweb for the review, I am merging it ;)

@samsonasik samsonasik merged commit e420c03 into codeigniter4:develop Sep 14, 2023
@samsonasik samsonasik deleted the str-vars branch September 14, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner Awaiting requested review from MGatner

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

+1 more reviewer

@datamweb datamweb datamweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @kenjis @datamweb