docs: Use validateData() to validate POST data only#8157
Closed
obozdag wants to merge 1 commit intocodeigniter4:developfrom
obozdag:patch-2
Closed
docs: Use validateData() to validate POST data only#8157obozdag wants to merge 1 commit intocodeigniter4:developfrom obozdag:patch-2
obozdag wants to merge 1 commit intocodeigniter4:developfrom
obozdag:patch-2
Conversation
Instead of withRequest(), use validateData() to validate POST data only. withRequest() uses $request->getVar() which returns $_GET, $_POST and $_COOKIE data in that order. Newer values override older values. Post values will be overriden by the cookies if they have the same name.
5 tasks
kenjis
reviewed
Nov 6, 2023
| or :ref:`$request->getRawInput() <incomingrequest-retrieving-raw-data>` | ||
| or :ref:`$request->getVar() <incomingrequest-getting-data>`, and an attacker | ||
| could change what data is validated. | ||
| Instead of withRequest(), use validateData() to validate POST data only. withRequest() uses $request->getVar() which returns $_GET, $_POST and $_COOKIE data in that order. Newer values override older values. Post values will be overriden by the cookies if they have the same name. |
Member
There was a problem hiding this comment.
This warning will be too long.
Why don't you add another warning about this addition, and move it to the top of the section?
Personally $this->validate() is not recommended.
Suggested change
| Instead of withRequest(), use validateData() to validate POST data only. withRequest() uses $request->getVar() which returns $_GET, $_POST and $_COOKIE data in that order. Newer values override older values. Post values will be overriden by the cookies if they have the same name. | |
| Instead of ``validate()``, use ``validateData()`` to validate POST data only. | |
| ``withRequest()`` uses ``$request->getVar()`` which returns ``$_GET``, ``$_POST`` | |
| or ``$_COOKIE`` data in that order (depending on php.ini | |
| `request-order <https://www.php.net/manual/en/ini.core.php#ini.request-order>`_). | |
| Newer values override older values. POST values may be overridden by the | |
| cookies if they have the same name. |
Contributor
Author
There was a problem hiding this comment.
Thanks for the edit. That is what I was trying to explain. But unfortunately I don't know this markup language used here. I would appreciate if you could do it, please.
Contributor
There was a problem hiding this comment.
See here it might help you.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/documentation.rst
Member
This was referenced Nov 7, 2023
Member
|
Closed by #8169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of withRequest(), use validateData() to validate POST data only. withRequest() uses $request->getVar() which returns $_GET, $_POST and $_COOKIE data in that order. Newer values override older values. Post values will be overriden by the cookies if they have the same name.
Description
Explain what you have changed, and why.
Checklist: