docs: fix incomingrequest.rst and note to getVar()#8170
Merged
kenjis merged 18 commits intocodeigniter4:developfrom Nov 9, 2023
Merged
docs: fix incomingrequest.rst and note to getVar()#8170kenjis merged 18 commits intocodeigniter4:developfrom
kenjis merged 18 commits intocodeigniter4:developfrom
Conversation
getVar() is not guaranteed to get POST data.
The method is not recommended.
getVar() does not return POST items.
getVar() is not recommended.
getVar() is not recommended.
getVar() is not recommended.
getVar() is not recommended.
The anchor text `here` is not recommened.
There is no param in getUserAgent().
michalsn
reviewed
Nov 8, 2023
michalsn
approved these changes
Nov 8, 2023
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
kenjis
changed the title
datamweb
approved these changes
Nov 9, 2023
Contributor
datamweb
left a comment
datamweb
left a comment
There was a problem hiding this comment.
I am glad that you are removing getVar() from the documente. 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
getVar()method is complicated and difficult to use.It is not recommended.
getVar()can be deprecated.Checklist: