Skip to content

test: update tests to use SiteURI#8196

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:test-use-SiteURI
Nov 14, 2023
Merged

test: update tests to use SiteURI#8196
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:test-use-SiteURI

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Nov 12, 2023 •
edited
Loading

Description
IncomingRequest is actually already using SiteURI.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Nov 12, 2023
datamweb
datamweb approved these changes Nov 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@kenjis kenjis merged commit db721a5 into codeigniter4:develop Nov 14, 2023
@kenjis kenjis deleted the test-use-SiteURI branch November 14, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @michalsn @datamweb