Skip to content

test: use array_sort_by_multiple_keys() in AbstractGetFieldDataTest#8506

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:test-refactor-AbstractGetFieldDataTest
Feb 3, 2024
Merged

test: use array_sort_by_multiple_keys() in AbstractGetFieldDataTest#8506
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:test-refactor-AbstractGetFieldDataTest

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Feb 3, 2024

Description

  • refactor test

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Feb 3, 2024
@kenjis kenjis merged commit a3b92fa into codeigniter4:develop Feb 3, 2024
@kenjis kenjis deleted the test-refactor-AbstractGetFieldDataTest branch February 3, 2024 23:56
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Feb 3, 2024

@datamweb Thank you for reviews!

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Feb 4, 2024

Run vendor/bin/rector process system --dry-run --no-progress-bar

Error: ] Could not process                                                      
         "/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendo
         r/symplify/easy-parallel/src/ValueObject/ParallelProcess.php" file, due
         to:                                                                    
         "Child process timed out after 120 seconds". On line: 108              

Error: ] Could not process some files, due to:                                  
         "Reached system errors count limit of 50, exiting...".                 

Error: Process completed with exit code 1.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7770165323/job/21189995850

@samsonasik
Copy link
Copy Markdown
Member

Reduce the job size may be needed.

-    $rectorConfig->parallel(120, 8, 15);
+    $rectorConfig->parallel(120, 8, 10);

@samsonasik
Copy link
Copy Markdown
Member

#8510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants