Merged
Conversation
kenjis
added
bug
kenjis
force-pushed
the
exception-rework-4.6
branch
from
0d6b649 to
a248547
Compare
Member
|
Looks good to me. |
kenjis
force-pushed
the
exception-rework-4.6
branch
2 times, most recently
from
5d7c14c to
f3cb449
Compare
kenjis
removed
the
docs needed
Member
Author
|
Updated code and added user guide. |
kenjis
force-pushed
the
exception-rework-4.6
branch
2 times, most recently
from
1225408 to
aba67c4
Compare
|
👋 Hi, @kenjis! |
kenjis
force-pushed
the
exception-rework-4.6
branch
from
aba67c4 to
b5921f6
Compare
|
👋 Hi, @kenjis! |
kenjis
force-pushed
the
exception-rework-4.6
branch
from
b5921f6 to
9d4c707
Compare
If there are more than one Exception class in the domain, provide a domain-level interface for capture of all exceptions.
kenjis
force-pushed
the
exception-rework-4.6
branch
from
9d4c707 to
f1359dd
Compare
MGatner
approved these changes
May 23, 2024
Member
|
UG changes look good, thanks for the thorough coverage. |
Member
Author
|
@MGatner Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #8470
Closes #4358
CodeIgniter\ExceptionsLogicExceptionRuntimeExceptionBadFunctionCallExceptionBadMethodCallExceptionInvalidArgumentExceptionExceptionInterfaceto catch all Exceptions in the domainFilesHTTPRouterCodeIgniter\Exceptions\ExceptionInterface\Exception(not\Error)\LogicExceptionor\RuntimeExceptionChecklist: