Skip to content

feat: [FileCollection] add function to reatain multiple patterns#8960

Merged
kenjis merged 13 commits intocodeigniter4:4.6from
christianberkman:feat-retain-multiple-patterns
Jun 15, 2024
Merged

feat: [FileCollection] add function to reatain multiple patterns#8960
kenjis merged 13 commits intocodeigniter4:4.6from
christianberkman:feat-retain-multiple-patterns

Conversation

@christianberkman
Copy link
Contributor

Description
Supersedes #8953

Add a method to FileCollection that accepts an array of strings to retain multiple patterns in the file collection.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

christianberkman and others added 9 commits June 10, 2024 23:24
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
@kenjis kenjis added enhancement PRs that improve existing functionalities 4.6 labels Jun 12, 2024
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
christianberkman and others added 2 commits June 12, 2024 13:04
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@christianberkman
Copy link
Contributor Author

LGTM! Thank you.

Thanks. I assume adding a similar function for removePattern() would just be for convenience sake since removePattern() can be called consecutively to remove multiple patterns, opposed to calling retainPattern consecutively.

Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@kenjis kenjis merged commit cfaa8f8 into codeigniter4:4.6 Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants