Skip to content

[4.6] fix: add validation message for min_dims#8988

Merged
kenjis merged 3 commits intocodeigniter4:4.6from
christianberkman:fix-min-dims
Jun 24, 2024
Merged

[4.6] fix: add validation message for min_dims#8988
kenjis merged 3 commits intocodeigniter4:4.6from
christianberkman:fix-min-dims

Conversation

@christianberkman
Copy link
Contributor

@christianberkman christianberkman commented Jun 22, 2024

Description
Add missing validation message for min_dims validation rule introduced in #8966

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.6 bug Verified issues on the current code behavior or pull requests that will fix them labels Jun 22, 2024
kenjis
kenjis previously approved these changes Jun 22, 2024
@kenjis kenjis changed the title fix: add validation message for min_dims [4.6] fix: add validation message for min_dims Jun 22, 2024
@kenjis
Copy link
Member

kenjis commented Jun 22, 2024

@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Jun 22, 2024
@kenjis kenjis dismissed their stale review June 22, 2024 09:27

docs needed

@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Jun 22, 2024
Co-authored-by: kenjis <kenji.uui@gmail.com>
@kenjis kenjis merged commit d4fee13 into codeigniter4:4.6 Jun 24, 2024
@kenjis
Copy link
Member

kenjis commented Jun 24, 2024

@christianberkman Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants