fix: [Filters] normalize $filters arguments#8994
Merged
kenjis merged 4 commits intocodeigniter4:4.6from Jun 29, 2024
Merged
Conversation
$filters arguments$filters arguments
3317bda to
bdfe019
Compare
$filters arguments$filters arguments
michalsn
approved these changes
Jun 25, 2024
datamweb
approved these changes
Jun 25, 2024
ddevsr
approved these changes
Jun 26, 2024
For consistency. Route filter arguments are already normalized.
bdfe019 to
81efd57
Compare
81efd57 to
f3e5504
Compare
datamweb
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR normalizes
$filtersarguments.Because Route filter's arguments are already normalized (trimmed).
CodeIgniter4/system/Filters/Filters.php
Line 489 in ab64aeb
CodeIgniter4/system/Filters/Filters.php
Lines 517 to 531 in ab64aeb
$filtersargumentsChecklist: