refactor: remove dependency on BaseConnection in TableName#9104
Merged
kenjis merged 1 commit intocodeigniter4:4.6from Aug 8, 2024
Merged
refactor: remove dependency on BaseConnection in TableName#9104kenjis merged 1 commit intocodeigniter4:4.6from
kenjis merged 1 commit intocodeigniter4:4.6from
Conversation
Remove dependency on BaseConnection.
kenjis
force-pushed
the
refactor-TableName
branch
from
b1cfed6 to
640de45
Compare
kenjis
changed the title
michalsn
approved these changes
Aug 5, 2024
ddevsr
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up #8748
TableNameshould not depend on DB Connection.Because it may be a table name in another database. See #9085
Checklist: