Skip to content

Conversation

@yassinedoghri
Copy link
Contributor

@yassinedoghri yassinedoghri commented Nov 27, 2025

Description
Following the previous PR (#9809), this is the second part of the CacheInterface refactor.

This PR adds native return types to all CacheInterface methods and updates the user guides accordingly.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@yassinedoghri yassinedoghri force-pushed the fix/cache-interface-2 branch 2 times, most recently from 8065d0f to 622dd8b Compare November 27, 2025 11:20
@yassinedoghri yassinedoghri changed the title DRAFT: feat(cache): add native return types to all CacheInterface methods feat(cache): add native return types to all CacheInterface methods Nov 27, 2025
+ remove deprecated `false` type in `getMetaData()` method
+ remove unnecessary @inheritdoc annotation
+ clarify deprecation removal of `false` type for `CacheInterface::getMetaData()`
@yassinedoghri yassinedoghri changed the title feat(cache): add native return types to all CacheInterface methods feat(cache): add native types to all CacheInterface methods Nov 28, 2025
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@yassinedoghri
Copy link
Contributor Author

Thank you for the reviews!

I don't know if it's important but the "Breaking change" and "4.7" labels are missing 😅

@michalsn michalsn added breaking change Pull requests that may break existing functionalities 4.7 labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.7 breaking change Pull requests that may break existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants