-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(cache): add native types to all CacheInterface methods #9811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yassinedoghri
wants to merge
4
commits into
codeigniter4:4.7
Choose a base branch
from
yassinedoghri:fix/cache-interface-2
base: 4.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(cache): add native types to all CacheInterface methods #9811
yassinedoghri
wants to merge
4
commits into
codeigniter4:4.7
from
yassinedoghri:fix/cache-interface-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8065d0f to
622dd8b
Compare
+ remove deprecated `false` type in `getMetaData()` method + remove unnecessary @inheritdoc annotation
+ clarify deprecation removal of `false` type for `CacheInterface::getMetaData()`
622dd8b to
ff35267
Compare
fba94bc to
2df6524
Compare
2df6524 to
cdc619e
Compare
paulbalandan
approved these changes
Nov 28, 2025
michalsn
approved these changes
Nov 28, 2025
Member
michalsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Contributor
Author
|
Thank you for the reviews! I don't know if it's important but the "Breaking change" and "4.7" labels are missing 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the previous PR (#9809), this is the second part of the CacheInterface refactor.
This PR adds native return types to all CacheInterface methods and updates the user guides accordingly.
Checklist: