Skip to content

chore: remove IncomingRequest deprecations #9851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
michalsn wants to merge 2 commits into
base: 4.7
Choose a base branch
from
Open

chore: remove IncomingRequest deprecations #9851

michalsn wants to merge 2 commits into from
+16 −514

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented Dec 20, 2025

Description
This PR removes deprecated methods from the IncomingRequest class.

The deprecated $config parameter has been removed from setPath(), and the method visibility has been changed from public to private.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added refactor Pull requests that refactor code 4.7 labels Dec 20, 2025
neznaika0
neznaika0 approved these changes Dec 20, 2025
View reviewed changes
Copy link
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Working on deprecations is important as new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@neznaika0 neznaika0 neznaika0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4.7 refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalsn @neznaika0 @paulbalandan