feat: prevent Maximum call stack size exceeded on client-managed requests
#9852
+168
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
reviewed
Dec 21, 2025
Comment on lines
+395
to
+402
| try { | ||
| $stats = $app->getPerformanceStats(); | ||
| if (! isset($stats['startTime']) || ! isset($stats['totalTime'])) { | ||
| return; | ||
| } | ||
| } catch (Throwable) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Can you elaborate on why we need a try/catch block here?
| } | ||
|
|
||
| $toolbar = service('toolbar', $config); | ||
| $stats = $app->getPerformanceStats(); |
Member
There was a problem hiding this comment.
Why are we calling this again?
| */ | ||
| public array $disableOnHeaders = [ | ||
| 'HX-Request', // HTMX partial requests | ||
| 'HX-Boosted', // HTMX boosted navigation |
Member
There was a problem hiding this comment.
You can't set HX-Boosted without having HX-Request, so the HX-Boosted is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Debug Toolbar injects HTML and JavaScript into every HTML response by default, which works for full page loads but causes issues for client-managed or partial requests (such as those from HTMX, Unpoly, or Hotwire Turbo) that expect clean HTML fragments. This can result in invalid HTML, duplicated scripts, or JavaScript errors like “Maximum call stack size exceeded.” To address this, support was added to skip Debug Toolbar HTML/JS injection for requests containing specific headers (e.g. HX-Request, HX-Boosted, X-Unpoly-Request, Turbo-Frame, Turbo-Visit), while still preserving Debugbar response headers for network-level debugging.
I don’t consider this PR a new feature. I believe it could have been to the develop branch, but since it introduces the
$disableOnHeadersproperty, I only PR’d it to the 4.7 branch.Checklist: