Add email null check #119
Merged
Add email null check #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
force-pushed
the
add-email-null-check
branch
from
64efa62 to
b7fd64f
Compare
kenjis
force-pushed
the
add-email-null-check
branch
from
b7fd64f to
0ea58dc
Compare
| throw new RuntimeException('Cannot get the User.'); | ||
| } | ||
|
|
||
| $userEmail = $user->getAuthEmail(); |
Contributor
There was a problem hiding this comment.
At this point calling getAuthEmail() is the same as just calling ->email, right? With no trait that needs the getAuth* methods do we even need them anymore?
Member
Author
There was a problem hiding this comment.
Yes, it is the same as calling getEmail(), so it is the same as ->email.
About getAuth*() methods, we don't need them now. But when we introduce Interface for User, probably we will need them. So I am okay to remove getAuth*() now.
MGatner
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to rebase after merging #110