-
Notifications
You must be signed in to change notification settings - Fork 142
fix: add missing Auth.registerSuccess for farsi
#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing Auth.registerSuccess for farsi
#174
Conversation
|
This is not must for this PR, but it seems your And how to update the PR branch: |
9bec59b to
97c4ebb
Compare
|
@kenjis I did what was said. Anyway, thank you, because you explained to me before that I should not use |
We don't know why. It is GitHub authentication error. |
|
A contributing factor could be that we still have the repository listed in composer.json even though we don't need it anymore: "repositories": [
{
"type": "vcs",
"url": "https://github.com/codeigniter4/CodeIgniter4"
}
],This might be triggering an unnecessary pull which adds a point of failure. |
|
We don't use |
|
Composer doesn't know what the repository contains until it fetches composer.json from it, so I believe it will be polled on every update even if we aren't using it. So yes, it is not required but could still be affecting our authentication errors. |
|
I tried creating a PR from mobile: #178 Never done that before, hopefully it worked. |
Yes.
Might be. |
|
I wonder if those 404 are actually part of the problem? |
Hi,
related to PR: #169