Skip to content

Conversation

@datamweb
Copy link
Collaborator

Hi,
related to PR: #169

@kenjis
Copy link
Member

kenjis commented May 25, 2022

This is not must for this PR, but it seems your develop is out of dated.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#syncing-develop

And how to update the PR branch:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#pushing-your-branch

@datamweb datamweb force-pushed the add-Auth.registerSuccess-fa branch from 9bec59b to 97c4ebb Compare May 25, 2022 23:15
@datamweb
Copy link
Collaborator Author

@kenjis I did what was said.
Everything has been updated in Local and github. But I do not know why GitHub Action still gets errors!

Anyway, thank you, because you explained to me before that I should not use pull. My always question was how to update the directory without using it(pull).
Here I found out.
Thank you.

@kenjis
Copy link
Member

kenjis commented May 26, 2022

But I do not know why GitHub Action still gets errors!

We don't know why. It is GitHub authentication error.

Error: Could not authenticate against github.com
                                             
  [Composer\Downloader\TransportException]   
  Could not authenticate against github.com  

@lonnieezell lonnieezell merged commit 033ce7e into codeigniter4:develop May 26, 2022
@datamweb datamweb deleted the add-Auth.registerSuccess-fa branch May 26, 2022 05:38
@MGatner
Copy link
Member

MGatner commented May 26, 2022

A contributing factor could be that we still have the repository listed in composer.json even though we don't need it anymore:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/codeigniter4/CodeIgniter4"
        }
    ],

This might be triggering an unnecessary pull which adds a point of failure.

@kenjis
Copy link
Member

kenjis commented May 26, 2022

We don't use codeigniter4/codeigniter4 here, so I think the repositories item does not matter.

@MGatner
Copy link
Member

MGatner commented May 26, 2022

Composer doesn't know what the repository contains until it fetches composer.json from it, so I believe it will be polled on every update even if we aren't using it.

So yes, it is not required but could still be affecting our authentication errors.

@MGatner
Copy link
Member

MGatner commented May 26, 2022

I tried creating a PR from mobile: #178

Never done that before, hopefully it worked.

@kenjis
Copy link
Member

kenjis commented May 26, 2022

Composer doesn't know what the repository contains until it fetches composer.json from it, so I believe it will be polled on every update even if we aren't using it.

Yes.

Loading composer repositories with package information
Using GitHub token authentication
Downloading https://api.github.com/repos/codeigniter4/CodeIgniter4
[200] https://api.github.com/repos/codeigniter4/CodeIgniter4
Downloading https://api.github.com/repos/codeigniter4/CodeIgniter4/contents/composer.json?ref=develop
[200] https://api.github.com/repos/codeigniter4/CodeIgniter4/contents/composer.json?ref=develop
Downloading https://api.github.com/repos/codeigniter4/CodeIgniter4/commits/develop
[200] https://api.github.com/repos/codeigniter4/CodeIgniter4/commits/develop
Downloading https://api.github.com/repos/codeigniter4/CodeIgniter4/contents/.github/FUNDING.yml
[404] https://api.github.com/repos/codeigniter4/CodeIgniter4/contents/.github/FUNDING.yml
Downloading https://api.github.com/repos/codeigniter4/.github/contents/FUNDING.yml
[404] https://api.github.com/repos/codeigniter4/.github/contents/FUNDING.yml
Downloading https://api.github.com/repos/codeigniter4/CodeIgniter4/tags?per_page=100
[200] https://api.github.com/repos/codeigniter4/CodeIgniter4/tags?per_page=100

So yes, it is not required but could still be affecting our authentication errors.

Might be.

@MGatner
Copy link
Member

MGatner commented May 26, 2022

I wonder if those 404 are actually part of the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants