Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented May 26, 2022

  • add auth_token_logins table to record Bearer Token type login attempts
  • use auth_token_logins in AccessTokens Authenticator
  • fix auth_token column type to not null
  • refactor

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little odd to have duplicate table structure (thanks to PHPCPD pointing that out) but the alternative seems messy.

@kenjis
Copy link
Member Author

kenjis commented May 26, 2022

The table structure may diverge in the future.
I don't know now.

@kenjis kenjis merged commit d22158f into codeigniter4:develop May 26, 2022
@kenjis kenjis deleted the feat-add-auth-token-logins-table branch May 26, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants