feat: add id_type in logins table
#181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
force-pushed
the
add-id-type-logins-table
branch
2 times, most recently
from
5490399 to
4612b1f
Compare
lonnieezell
approved these changes
May 27, 2022
MGatner
requested changes
May 27, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
I like this better than the prefixes. A few suggestions.
kenjis
force-pushed
the
add-id-type-logins-table
branch
from
4612b1f to
a73621e
Compare
Co-authored-by: MGatner <mgatner@icloud.com>
kenjis
force-pushed
the
add-id-type-logins-table
branch
from
194a0f5 to
edd3510
Compare
No need to worry about operator precedence.
MGatner
requested changes
May 28, 2022
| 'id' => ['type' => 'int', 'constraint' => 11, 'unsigned' => true, 'auto_increment' => true], | ||
| 'ip_address' => ['type' => 'varchar', 'constraint' => 255], | ||
| 'user_agent' => ['type' => 'varchar', 'constraint' => 255, 'null' => true], | ||
| 'id_type' => ['type' => 'varchar', 'constraint' => 255], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to rebase after merging #177Identifiers can be added, and it will be not possible to determine what they are just from the identifier string.
Currently,
token:is also added to access tokens.Also, if there is no constraint, it is not possible to tell whether it is an
emailor ausernamejust from the string.It is easier to know what it is if we add a column for identifier type.
id_typeinauth_loginsandauth_token_loginsemail_password,username,magic-link, andaccess_tokenCheckQueryReturnTraitID_TYPE_*inSessionandAccessTokens