refactor: add return types #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
To automate this for void returns, you can use the void_return rule of php-cs-fixer. However, that rule can break public API.
Member
Author
|
@paulbalandan Shield is under pre-release. We don't care small breaking changes so much. |
MGatner
approved these changes
Aug 15, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
I usually run this manually with Psalm's CLI arguments, but maybe we should think about making this change in DevKit.
datamweb
approved these changes
Aug 16, 2022
kenjis
force-pushed
the
fix-return-types
branch
from
cccb135 to
1de5905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
void_returnrule for php-cs-fixer