Skip to content

refactor: fix PHPStan error #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenjis merged 2 commits into from
Sep 2, 2022
Merged

refactor: fix PHPStan error #416

kenjis merged 2 commits into from
Sep 2, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Sep 2, 2022 •
edited
Loading

  • fix PHPStan error 
    Error: Offset 'except' on array in isset() always exists and is not nullable.
 ------ -------------------------------------------------------------- 
  Line   src/Auth.php                                                  
 ------ -------------------------------------------------------------- 
  109    Offset 'except' on array in isset() always exists and is not  
         nullable.                                                     
 ------ --------------------------------------------------------------
  • update coding style

Because of:

  • Upgrading friendsofphp/php-cs-fixer (v3.10.0 => v3.11.0)
  • Upgrading phpstan/phpstan (1.8.2 => 1.8.3)

@kenjis
refactor: remove unneeded isset($config['except']
0faf478 
To fix PHPStan error:
Error: Offset 'except' on array in isset() always exists and is not nullable.
 ------ --------------------------------------------------------------
  Line   src/Auth.php
 ------ --------------------------------------------------------------
  109    Offset 'except' on array in isset() always exists and is not
         nullable.
 ------ --------------------------------------------------------------
@kenjis
style: composer cs-fix
19993c4
@kenjis kenjis changed the title refactor: fix PPStan error refactor: fix PHPStan error Sep 2, 2022
@kenjis kenjis added the refactor Pull requests that refactor code label Sep 2, 2022
@kenjis kenjis mentioned this pull request Sep 2, 2022
Merged
datamweb
datamweb approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix with the speed of light😄

@kenjis kenjis merged commit 6d15d8c into codeigniter4:develop Sep 2, 2022
@kenjis kenjis deleted the fix-phpstan-error branch September 2, 2022 00:38
@kenjis
Copy link
Member Author

kenjis commented Sep 2, 2022

Thank you for your approval!

MGatner
MGatner reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see PHPStan doing even better with our complex Config files! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner left review comments

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @MGatner