Skip to content

test: use short classname for config() #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2023
Merged

test: use short classname for config() #803

merged 1 commit into from
Aug 29, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Aug 26, 2023 •
edited
Loading

Follow-up #796
Ref #802

This PR fixes the following test error with CI v4.4.0:

1) Tests\Unit\Authentication\JWT\JWTManagerTest::testParseCanSpecifyKey
ErrorException: Undefined array key "mobile"

/home/runner/work/shield/shield/src/Authentication/JWT/Adapters/FirebaseAdapter.php:145
/home/runner/work/shield/shield/src/Authentication/JWT/Adapters/FirebaseAdapter.php:112
/home/runner/work/shield/shield/src/Authentication/JWT/JWSEncoder.php:62
/home/runner/work/shield/shield/src/Authentication/JWTManager.php:[73](https://github.com/codeigniter4/shield/actions/runs/5984579479/job/16235976345?pr=801#step:11:74)
/home/runner/work/shield/shield/tests/Unit/Authentication/JWT/JWTManagerTest.php:311

@datamweb datamweb changed the title test: use short classname for config() test: use short classname for config() Aug 26, 2023
@kenjis
test: use short classname for config()
a90e40a 
We should use the same classname in the product code.
@kenjis kenjis force-pushed the fix-test-config-fqcn branch from 5d91b89 to a90e40a Compare August 27, 2023 00:42
@kenjis
Copy link
Member Author

kenjis commented Aug 27, 2023

I just changed the commit message.
This PR is no problem, but it seems to be better to fix the config() behavior.

@kenjis kenjis merged commit 05e033d into codeigniter4:develop Aug 29, 2023
@kenjis kenjis deleted the fix-test-config-fqcn branch August 29, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @datamweb