Skip to content

docs: add note for removing email from registration in customization/login_identifier #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenjis merged 2 commits into from
Oct 17, 2023
Merged

docs: add note for removing email from registration in customization/login_identifier #906

kenjis merged 2 commits into from
Oct 17, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Oct 15, 2023

Description
See #904

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Improvements or additions to documentation label Oct 15, 2023
@kenjis kenjis mentioned this pull request Oct 16, 2023
Closed
datamweb
datamweb approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@kenjis kenjis force-pushed the docs-improve-customization/login_identifier branch from da3dd66 to d6aad43 Compare October 16, 2023 01:08
@kenjis
Copy link
Member Author

kenjis commented Oct 16, 2023

I changed the description to a note.
Because this page explains how to change the login process, not the registration process.

@kenjis kenjis merged commit 9fbdaf4 into codeigniter4:develop Oct 17, 2023
@kenjis kenjis deleted the docs-improve-customization/login_identifier branch October 17, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @datamweb