Feat & Fix: Code test at 25.03.2021 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full Task Description: In the shopify-section "usp-services", on mobile it should only show 1 usp per line (<768px).
Full Task Description: In the shopify-section "usp-services" the icons should be rendered below the text
Full Task Description: On the homepage the heading elements (h1, h2, h3) are not in a sequentially-descending order, please fix this.
Full Task Description: Do a lighthouse check on SEO for mobile and fix the issue.
Full Task Description: Create a new shopify-section with a text and image pane. (See Assessment designs). Use this as image. The 2000x1000 in the url can be adjusted to render smaller images and crops.
Full Task Description: The footer navigation shows to much on mobile, make it 3 collapsible panes showing only the headings. Write a simple javascript/jQuery function that will make the panes collapse and open when the heading is clicked.
giuggiii
added a commit
to giuggiii/code-assessment
that referenced
this pull request
Oct 20, 2023
…Changes implemented: I added an inner wrapper to the usp cards so that I could more consistently use flexbox to change the order of the icons, Fix codeinternetapplications#2
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assignments where made following the readme file.
Task 1: ✓
Task 2: ✓
Task 3: ✓
Task 4: ✓
Task 5: ✓
Task 6: ✓
Task 7:
Task 8: