Skip to content

Conversation

@neelimagoogly
Copy link
Contributor

Updating Header.js and index.js to add functionality to the Header component.

Pull Request Template
Description
In in homepage of 'Code is Science' website , if we click on the 'Read and Sign the Manifesto' , it doesnot respond.
I have fixed this issue.

Fixes # (issue)
I have included the following changes to solve the issue:

  • React Router Navigation
  • Now when we click on the 'Read and Sign the Manifesto' button , it responds and redirects the user to the page where the user can read and sign the manifesto.

[ Yes] New feature (non-breaking change which adds functionality).

[ Yes] This change requires a documentation update.

How Has This Been Tested?
This has been tested in my local server 'localhost:3000'.

Checklist:
[ Yes] My code follows the style guidelines of this project.
[Yes ] I have performed a self-review of my own code.
[Yes ] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@neelimagoogly neelimagoogly mentioned this pull request Apr 16, 2022
@neelimagoogly
Copy link
Contributor Author

Now I have successfully resolved this issue in a single PR #144 and and I have closed PR #138 .
Please review this .

@padmajabhol
Copy link
Member

Please consider opening an issue prior to making a PR.

@padmajabhol
Copy link
Member

@ikayz I might need your approval here before we can set this to merge.

@ikayz ikayz merged commit be8eda8 into codeisscience:development Apr 25, 2022
Copy link
Contributor

@ikayz ikayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants