♻️ [Refactor] 중간 발표 이전 리팩토링 #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
haegu97
approved these changes
Dec 16, 2024
sunnwave
approved these changes
Dec 16, 2024
| import { useState } from 'react'; | ||
| import { useRouter } from 'next/navigation'; | ||
|
|
||
| export const usePopup = () => { |
There was a problem hiding this comment.
이 훅을 모든 도메인에서 사용할 수있게 개선해보면 어떨까요?
club-create에서만 쓸 수 있는데, 다른 곳에서도 사용할 수 있게 개선하면 좋을 것 같습니다!
There was a problem hiding this comment.
const popup = usePopup();
// 선언적으로 만들어주기
const successPopup = popup.open( (open, close ) => <컴포넌트 open={open} close={close} />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
미리보기, 사용방법 및 결과물
기타 참고사항